I don't think we should hardcode a git reference of ring like this. Until a new version has been released we should keep the existing versions. Folks should still be able to use cargo's patch feature to override the ring version until then.

I don't think we should hardcode a git reference of ring like this. Until a new version has been released we should keep the existing versions.

Sorry, bad communication on my end. I don't expect this to be merged until the version is actually released! Hence the draft PR.

I only opened this PR to make sure we can get this released ASAP once ring actually releases the new version and to be able to test that we can do what we want to do (melekes/rust-libp2p#12) with these changes.

Folks should still be able to use cargo's patch feature to override the ring version until then.

Negative. This only works if the version in the Cargo.toml is not bumped yet. ring already has it set to 0.17.0-not-released-yet so a [patch.crates-io]-entry in a manifest is a no-op.

I don't think we should hardcode a git reference of ring like this. Until a new version has been released we should keep the existing versions.

Sorry, bad communication on my end. I don't expect this to be merged until the version is actually released! Hence the draft PR.

I only opened this PR to make sure we can get this released ASAP once ring actually releases the new version and to be able to test that we can do what we want to do (melekes/rust-libp2p#12) with these changes.

I'd appreciate a review to make sure we aren't blocked on something once ring cuts a new release!

LGTM but this needs rebasing

I fixed the conflicts by merging. I hope that is fine! You seem to squash-merge in here so I didn't bother with a rebase :)

@yngrtc This is now ready for review.

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ad4ceb5) 61.50% compared to head (a3f7c6d) 61.52%.

❗ Current head a3f7c6d differs from pull request most recent head 1ccc71b. Consider uploading reports for the commit 1ccc71b to get more accurate results

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   61.50%   61.52%   +0.01%     
==========================================
  Files         529      529              
  Lines       48836    48838       +2     
  Branches    12356    12364       +8     
==========================================
+ Hits        30039    30048       +9     
+ Misses       9614     9604      -10     
- Partials     9183     9186       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Could you fix clippy/fmt error?

Could you fix clippy/fmt error?

It seems unrelated to my changes and likely caused by an implicit dependency bump as you are not tracking Cargo.lock in git. Do you want it fixed in this PR or in a separate one?

I sent a PR here: #503

Rebase it?

Rebase it?

I am assuming because you squash-merge anyway in here that merge was fine too. Btw, there is a setting in GitHub to "always suggest updating branch" that you can enable to always have the button for manually merging master in PR branches!